Add support for different HMAC algorithms. #63
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RFC 6238 (https://tools.ietf.org/html/rfc6238) states:
This PR adds support for that.
I've also added additional tests to
codeProvider()
based on the code and output of the sample code in the RFC to validate the changes.As a side effect of implementing the above, I've also fixed the case where if you change the
_codeLength
,verifyCode()
always returned false for any value other than6
, and added some boilerplate at the top ofGoogleAuthenticatorTest.php
to make the tests run under phpunit 6+