Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introducing namespace #47

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Conversation

chaos0815
Copy link

As the title says the code is now using a namepsace.
I've adjusted the test accordingly.
please excuse the format changes. Bad habit of mine.

* code styling
* using class constant in tests
@chaos0815 chaos0815 mentioned this pull request May 17, 2017
@chaos0815
Copy link
Author

Sorry for the erratic commits. but I'm not used to working with travis.

@chaos0815
Copy link
Author

Well, is there something opposing a merge?
Asking for a friend.

@Dennis1993
Copy link

Why a space between the dots?
That makes it very confusing

@chaos0815
Copy link
Author

@Dennis1993 whitespace between operands confuses you?

@Ryan6578
Copy link

@chaos0815 I think this project is abandoned.

@chaos0815
Copy link
Author

@PHPGangsta
Michael, some feedback would be appreciated on why you would not accept this pull request.
I believe introducing namespaces is the right way to go and I don't see any reasons not to.

@Ryan6578
Copy link

@chaos0815 Once again, I'm pretty sure the project is abandoned. He's not going to get back to you because he is no longer interested in maintaining the project.

@chaos0815
Copy link
Author

@Ryan6578 and you would know because?

@Ryan6578
Copy link

@chaos0815 Look at the repository. The owner's last commit was nearly 2 years ago, the last time he merged a PR was nearly 2 years ago. There's been no activity from him on this repository since then. That's how I know.

@MarkMaldaba
Copy link

Also, one of the nice things about this implementation, as opposed to some of the alternative libraries that are out there, is that it works on pretty much all PHP versions, including older PHP 5. Therefore, I don't think it's a great idea to introduce this kind of change, which removes that support for no actual benefit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants