-
Notifications
You must be signed in to change notification settings - Fork 697
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introducing namespace #47
base: master
Are you sure you want to change the base?
Conversation
* code styling * using class constant in tests
usefull when dealing with mobile devices or want to use other QR code generators
Sorry for the erratic commits. but I'm not used to working with travis. |
Well, is there something opposing a merge? |
Why a space between the dots? |
@Dennis1993 whitespace between operands confuses you? |
@chaos0815 I think this project is abandoned. |
@PHPGangsta |
@chaos0815 Once again, I'm pretty sure the project is abandoned. He's not going to get back to you because he is no longer interested in maintaining the project. |
@Ryan6578 and you would know because? |
@chaos0815 Look at the repository. The owner's last commit was nearly 2 years ago, the last time he merged a PR was nearly 2 years ago. There's been no activity from him on this repository since then. That's how I know. |
Also, one of the nice things about this implementation, as opposed to some of the alternative libraries that are out there, is that it works on pretty much all PHP versions, including older PHP 5. Therefore, I don't think it's a great idea to introduce this kind of change, which removes that support for no actual benefit. |
As the title says the code is now using a namepsace.
I've adjusted the test accordingly.
please excuse the format changes. Bad habit of mine.