Ruleset: prevent false positives on random_compat polyfill code #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When `PHPCompatibility(ParagonieRandomCompat)` is run over the code in the `random_compat` repo itself, it will detect some non-issues. The code in the files is all wrapped within proper `defined()`, `version_compare()` and/or `function_exists()` conditions and will never be executed on incompatible PHP versions. This simple change prevents these non-issues from being reported. This fix does rely on people having installed the package in a directory called `random_compat`.
wimg
approved these changes
Oct 8, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When notifying the polyfill repos about the polyfill rulesets, I came across this issue and figured we could fix that.
When
PHPCompatibility(ParagonieRandomCompat)is run over the code in therandom_compatrepo itself, it will detect some non-issues.The code in the files is all wrapped within proper
defined(),version_compare()and/orfunction_exists()conditions and will never be executed on incompatible PHP versions.This simple change prevents these non-issues from being reported.
This fix does rely on people having installed the package in a directory called
random_compat.