Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 4 custom model parameters #83

Merged
merged 1 commit into from
Sep 18, 2024
Merged

Conversation

yes-github
Copy link
Collaborator

  • 新增4个自定义模型的参数:
    • det_model_dir :检测模型目录路径
    • rec_model_dir :识别模型目录路径
    • rec_char_dict_path :识别模型字典文件路径
    • cls_model_dir :分类模型目录路径

Copy link
Collaborator

@GreatV GreatV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GreatV GreatV merged commit 3201d08 into PFCCLab:main Sep 18, 2024
1 check passed
@GreatV
Copy link
Collaborator

GreatV commented Sep 18, 2024

后面可不可以使用一个配置文件(如:config/config.json或者config/settings.yaml),用来存储这些cli参数。这样用户在需要修改多个参数时,直接修改配置文件即可,不需要挨个指定参数。

@GreatV
Copy link
Collaborator

GreatV commented Sep 18, 2024

感谢你的贡献,为你添加了write权限。
image

@yes-github
Copy link
Collaborator Author

后面可不可以使用一个配置文件(如:config/config.json或者config/settings.yaml),用来存储这些cli参数。这样用户在需要修改多个参数时,直接修改配置文件即可,不需要挨个指定参数。

很好的建议,后续适当的时候应该加上

@yes-github yes-github deleted the add_model_args branch September 23, 2024 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants