Sensitive api #20
Open
Sensitive api #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rbonifacio
requested changes
Oct 30, 2020
| case method(_, _, nm, _, _, _): name = name+nm; | ||
|
|
||
| } | ||
| return name; | ||
| } |
There was a problem hiding this comment.
Do we really need these functions to implement the feature of mining calls to sensitive APIs? Perhaps you have implemented them just to familiarize yourselves with the architecture / and the Rascal language. If this is the case, I would recommend removing these methods.
| }; | ||
|
|
||
| return ""; | ||
| } |
There was a problem hiding this comment.
We should discuss again this implementation. IMO, we should simplify the interface of the sensitiveFind function. Actually, even the name is not really good. It should receive two arguments: a list of strings with the signature of sensitive methods and an ExecutionContext. Only in this way I could use this implementation in a pipeline with a set of analyzes. This is a bit tough to explain here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first implementation of the module to collect sensitive APIs from invoked methods