Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for revise #233

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

frankier
Copy link
Contributor

@frankier frankier commented Nov 6, 2024

No description provided.

@frankier frankier mentioned this pull request Nov 6, 2024
@frankier
Copy link
Contributor Author

frankier commented Nov 6, 2024

These seem to work on Julia 1.10 only, but not Julia 1.11 OR Julia 1.6.

Will support for Julia 1.6 be dropped soon? In that case, I could look at fixing Julia 1.11 --- might be a bit of a pain since it seems the mock module monkeypatching technique doesn't work anymore.

@ndortega
Copy link
Member

@frankier The next major update is to migrate over to 1.10

@frankier frankier force-pushed the revise-tests branch 2 times, most recently from 9cffea3 to 83d5b9d Compare November 19, 2024 15:35
@frankier
Copy link
Contributor Author

Okay. It works on Julia 1.11 now so can be merged once 1.6 is dropped.

@frankier frankier marked this pull request as ready for review November 20, 2024 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants