Commit the Big GUI Update: V2

[ghost]

:(

#85

[josephworks]

This does fix the previous pr to an extent but I saw a few issues

• You are gitignoring /src
• You are un binding some keybinds

Please fix this

[josephworks]

Undo the keybind changes
Dont gitignore /src

[ghost]

okay okay sorry

[ghost]

done

[ghost]

should i gitignore /minecraft though or keep duplicates?

bc my original was to ignore the duplicate /minecraft folder

[josephworks]

I don’t quit understand, if you gitignore that directory, then no changes made to it will pop up to be added and pushed. Why would you do that?

[josephworks]

Also, I see that there are 3000 changes. The changes won’t even load in on my school iPad. Why are there so many?

[josephworks]

Update: I found the issue

you refactored the Minecraft folder to src/minecraft, don’t do that.

please undo, or create a different PR to talk about that and apply your change.

[ghost]

Update: I found the issue

you refactored the Minecraft folder to src/minecraft, don’t do that.

please undo, or create a different PR to talk about that and apply your change.

YOU SAID UNGITIGNORE THE SRC LOLOLOLOL SO I DID IT

also the default mcp dir is src/minecraft so i moved everything there and once i was ready to push everything i copied minecraft from src/minecraft to the minecraft dir LOL

and no we dont do a little refactoring thats just how mcp does it

sorry for my munky brain

[ghost]

im reignoring /src if u dont want to 300000 changes LOL

[josephworks]

Do not reignore/commit/push src/

It is not relevant to this project and could cause issues down the line.

You need to manually stage your changes and push them. Adding something to the Gitignore cause it fixes your auto-staging isn't good and healthy for this project.

[ghost]

Then do you not want the 300k changes or do you want me to regitignore? I might as well ditch this altogether.

I'm following the "same formatting" wavelength has, with one minecraft/ folder and no src/ in sight.

[josephworks]

You are forgetting there is a middle-ground. You need to manually stage the changes you want to push.

Oxid's convention is to not have src/ or gitignore src/ and you are not following that.

Are you auto-staging btw?

[ghost]

1: Ok
2: I need to remove MCP then so I can't test it and see what's gone wrong without having an extra project
3: Yes I am with git add --all and using the gitignore

[ghost]

Still waiting for an update or merge...

I'll close this in a week if there's no response.

[sigmaclientwastaken]

when merge

[ghost]

when merge

i have no idea whatsoever

3 days before close btw, probably won't get a response :)
if you want the update at all (me when no response in a week), use my branch.

[sigmaclientwastaken]

1 more day until close

[ghost]

yup

i wont delete my branch tho
if i want to ig i can update my branch when v1 comes out

@josephworks @OxideWaveLength

[sigmaclientwastaken]

yup

i wont delete my branch tho
if i want to ig i can update my branch when v1 comes out

@josephworks @OxideWaveLength

I made a pull request on your fork

[ghost]

Alr, time to delete this PR. If you want my fork, go to:
https://github.com/AcaiBerii/Minecraft-Hack-BaseClient

[josephworks]

@OxideWaveLength yeah, you need to get your act together. Cloning, testing, and PRing doesn’t take much time and @AcaiBerii put even more time into his work compared to how long it will take to review and accept. You seriously wronged him by not getting to the PR in reasonable time.

@AcaiBerii I don’t see any reason for you to close the PR. If I was you I would leave a message giving a reason on why you will not continue putting effort into this PR and leave it as-is.

A am very disappointed to see a Pull Request end up like this. This isn’t right and shouldn’t of happened.

[ghost]

I don't feel like needing to leave open a PR like this just for it to go completely unnoticed and unmerged by Oxide, with no response for over 2 weeks.

I'll reopen this if you want, but it's really unnecessary if I don't at least get some activity on this.