-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cookiecutter #6
Cookiecutter #6
Conversation
Welcome, new contributor! It appears that this is your first Pull Request. To give credit where it's due, we ask that you add your information to the
Please make sure you've read our contributing guide. We look forward to reviewing your Pull Request shortly ✨ |
@coxipi This is ready for final review and merge. I'll tag a v0.1.0 release once this PR is merged. |
@@ -29,7 +33,7 @@ on: | |||
- pyproject.toml | |||
- tests/**.py | |||
- tox.ini | |||
- xsdba/__init__.py | |||
- src/xsdba/__init__.py |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm confused about the change, since it's a whole new repo. Is this something about CookieCutter previously not respecting this structure with src/...
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The first commit was a generic Github template, and now you're applying your own CookieCutter template?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are a lot of moving parts and sometimes I forget to add certain files. The src
structure is relatively new, and I'm still moving the template over to it, so it seems.
I'll probably be pushing one more change (the issue about numpydoc that I raised is fixed). I'll merge soon after!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, although I have very low knowledge on this.
Pull Request Checklist:
number
) and pull request (:pull:number
) has been added.What kind of change does this PR introduce?
Does this PR introduce a breaking change?
No.
Other information:
Refer to https://github.com/Ouranosinc/cookiecutter-pypackage
Numpydoc was disabled due to issue with their CLI on conda and PyPI (pre-commit hooks work as intended).