Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Proper fix for loess linalg error - non-random tests #2020

Merged
merged 4 commits into from
Dec 11, 2024
Merged

Proper fix for loess linalg error - non-random tests #2020

merged 4 commits into from
Dec 11, 2024

Conversation

SarahG-579462
Copy link
Contributor

@SarahG-579462 SarahG-579462 commented Dec 11, 2024 •
edited by Zeitsperre
Loading

Pull Request Checklist:

  • This PR addresses an already opened issue (for bug fixes / features)
  • Tests for the changes have been added (for bug fixes / features)
    • (If applicable) Documentation has been added / updated (for bug fixes / features)
  • CHANGELOG.rst has been updated (with summary of main changes)
    • Link to issue (:issue:number) and pull request (:pull:number) has been added

What kind of change does this PR introduce?

  • Non-random tests are, in my opinion, better than random tests. This fixes the data for test_loess_smoothing_nan to be something known to work. Loess_smoothing does not work on singular matrices (which are very rare to occur randomly, but do occur).
  • Also removes the too harsh condition on np.linalg.LinAlgError, which could occur for other reasons than singular matrices.

@github-actions github-actions bot added the sdba Issues concerning the sdba submodule. label Dec 11, 2024
Zeitsperre
Zeitsperre approved these changes Dec 11, 2024
View reviewed changes
Copy link
Collaborator

@Zeitsperre Zeitsperre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Approved for additional tests label Dec 11, 2024
@Zeitsperre Zeitsperre merged commit 61b6bbc into main Dec 11, 2024
21 checks passed
@Zeitsperre Zeitsperre deleted the sg_fix_linalg_proper branch December 11, 2024 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Zeitsperre Zeitsperre Zeitsperre approved these changes

Assignees
No one assigned
Labels
approved Approved for additional tests sdba Issues concerning the sdba submodule.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SarahG-579462 @Zeitsperre