Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix all-nan slices in ExtremeValues #1983

Merged
merged 5 commits into from
Oct 31, 2024
Merged

Fix all-nan slices in ExtremeValues #1983

merged 5 commits into from
Oct 31, 2024

Conversation

coxipi
Copy link
Contributor

@coxipi coxipi commented Oct 31, 2024 •
edited by Zeitsperre
Loading

Pull Request Checklist:

  • This PR addresses an already opened issue (for bug fixes / features)
    • This PR fixes #xyz
  • Tests for the changes have been added (for bug fixes / features)
    • (If applicable) Documentation has been added / updated (for bug fixes / features)
  • CHANGELOG.rst has been updated (with summary of main changes)
    • Link to issue (:issue:number) and pull request (:pull:number) has been added

What kind of change does this PR introduce?

  • All-nan slices were previously broken in _extremes_train_1d, now there is a fast-track that treats all-nan separately.

Does this PR introduce a breaking change?

No

Other information:

@github-actions github-actions bot added the sdba Issues concerning the sdba submodule. label Oct 31, 2024
coxipi
coxipi commented Oct 31, 2024
View reviewed changes
xclim/sdba/_adjustment.py Outdated Show resolved Hide resolved
RondeauG
RondeauG approved these changes Oct 31, 2024
View reviewed changes
Copy link
Contributor

@RondeauG RondeauG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Approved for additional tests label Oct 31, 2024
@Zeitsperre Zeitsperre merged commit f9c2d3e into main Oct 31, 2024
28 of 29 checks passed
@Zeitsperre Zeitsperre deleted the allnan_extremes branch October 31, 2024 14:58
@coxipi coxipi mentioned this pull request Oct 31, 2024
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RondeauG RondeauG RondeauG approved these changes

Assignees
No one assigned
Labels
approved Approved for additional tests sdba Issues concerning the sdba submodule.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@coxipi @RondeauG @Zeitsperre