Fix injection of added parameters #1981
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist:
number
) and pull request (:pull:number
) has been addedWhat kind of change does this PR introduce?
The issue was that a YAML definition of an indicator was not able to inject (set) the
indexer
parameter on indicators that inherited fromIndexingIndicator
(i.e. indicators that rely on a class-level implementation of the indexing, instead of compute-level one).This reorganizes how these class-added arguments are handled. It also renames them "added" arguments instead of "injected" to clear the confusion. "injection" now only means an indicator argument that is set when creating a derived indicator (that what most YAML definitions do). "added" is an argument that is not in the compute function, but added by the class.
The example YAML is modified and a test is added using this modification.
Does this PR introduce a breaking change?
No.
The feature was not really documented and now it works instead of not.
Other information: