Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin xarray to deal with polyfit/polyval regression #1978

Merged
merged 2 commits into from
Oct 30, 2024
Merged

Conversation

Zeitsperre
Copy link
Collaborator

@Zeitsperre Zeitsperre commented Oct 30, 2024

Pull Request Checklist:

  • This PR addresses an already opened issue (for bug fixes / features)
    • This PR fixes #xyz
  • Tests for the changes have been added (for bug fixes / features)
    • (If applicable) Documentation has been added / updated (for bug fixes / features)
  • CHANGELOG.rst has been updated (with summary of main changes)
    • Link to issue (:issue:number) and pull request (:pull:number) has been added

What kind of change does this PR introduce?

  • Pins xarray such that version 2024.10.0 is not compatible with xclim.

Does this PR introduce a breaking change?

Yes. xarray v2024.10.0 is considered to be broken according to our configurations. The pin will stay in place until we drop xarray newer than this version.

Other information:

pydata/xarray#9690
pydata/xarray#9691

The issue is currently fixed upstream, so the next release of xarray should have no issues.

@Zeitsperre Zeitsperre added bug Something isn't working dependencies Pull requests that update a dependency file labels Oct 30, 2024
@Zeitsperre Zeitsperre requested a review from aulemahal October 30, 2024 16:12
@Zeitsperre Zeitsperre self-assigned this Oct 30, 2024
@Zeitsperre Zeitsperre added the priority Immediate priority label Oct 30, 2024
@github-actions github-actions bot added the approved Approved for additional tests label Oct 30, 2024
@Zeitsperre Zeitsperre merged commit 7e4b1ab into main Oct 30, 2024
28 checks passed
@Zeitsperre Zeitsperre deleted the pin-xarray branch October 30, 2024 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Approved for additional tests bug Something isn't working dependencies Pull requests that update a dependency file priority Immediate priority
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants