Fix subdaily rate2amount, add hydro transformation from lwe thickness to amount #1963
+24
−4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist:
rate2amount
with smaller-than-daily frequencies #1962number
) and pull request (:pull:number
) has been addedWhat kind of change does this PR introduce?
_rate_to_amount_converter
relied on theFREQ_UNITS
directly, now it goes throughinfer_sampling_units
instead. In exchange for slightly more code, this fixes the issue for sub-daily freqs and gives a better error for frequencies xclim can't understand.Does this PR introduce a breaking change?
No.