Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch release: V0.52.1 #1918

Merged
merged 11 commits into from
Sep 16, 2024
Merged

Patch release: V0.52.1 #1918

merged 11 commits into from
Sep 16, 2024

Conversation

Zeitsperre
Copy link
Collaborator

@Zeitsperre Zeitsperre commented Sep 11, 2024

Pull Request Checklist:

  • This PR addresses an already opened issue (for bug fixes / features)
    • This PR fixes #xyz
  • Tests for the changes have been added (for bug fixes / features)
    • (If applicable) Documentation has been added / updated (for bug fixes / features)
  • CHANGELOG.rst has been updated (with summary of main changes)
    • Link to issue (:issue:number) and pull request (:pull:number) has been added

What kind of change does this PR introduce?

  • Fixes a dependency pin that was causing environment resolution errors on PAVICS

Does this PR introduce a breaking change?

No.

Other information:

Private: https://github.com/Ouranosinc/pavics-jupyter-env-issues/issues/13#issuecomment-2343804116

@Zeitsperre
Copy link
Collaborator Author

The tag will be made from the last commit here before merging to main.

@Zeitsperre Zeitsperre added bug Something isn't working priority Immediate priority labels Sep 11, 2024
Copy link

@tlvu tlvu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Zeitsperre
Copy link
Collaborator Author

This PR will bump the version to the next point patch version (v0.52.2-dev.x). I'll be proposing a better system soon to not run into this problem again.

@aulemahal
Copy link
Collaborator

I've been made aware that the latest release of xarray contains my changes concerning the "decimal_year" stuff which has broken xclim. I'll try to insert a fix here today!

@Zeitsperre
Copy link
Collaborator Author

@aulemahal v0.52.1 has already been released, unfortunately. I might need to push another patch, haha.

@Zeitsperre Zeitsperre added the approved Approved for additional tests label Sep 13, 2024
@aulemahal
Copy link
Collaborator

has already been released

And I even approved the deployment 🙃 . I was mislead by the fact that this PR was still open ;)!

Well, this could have been expected from my decision to use a private
function that I myself removed... But I had forgotten that we were
explicitly using it.

So this fixes xclim with xarray 2024.09.0 by having a try-except for the
import of the decimal year stuff.

Also, removed the deprecated function.

As of xarray 2024.09, the "decimal year" can be calculated through
`times.dt.decimal_year`, no need to use a private function.

This also adds the missing `branch` specifiers to `open_dataset` calls
in the notebooks.

---------

Co-authored-by: Trevor James Smith <[email protected]>
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@github-actions github-actions bot added the docs Improvements to documenation label Sep 16, 2024
@coveralls
Copy link

Coverage Status

coverage: 89.402%. remained the same
when pulling 3748b16 on v0.52.1
into 9d5333f on main.

@Zeitsperre Zeitsperre merged commit fc1866a into main Sep 16, 2024
21 checks passed
@Zeitsperre Zeitsperre deleted the v0.52.1 branch September 16, 2024 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Approved for additional tests bug Something isn't working docs Improvements to documenation priority Immediate priority
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants