-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Patch release: V0.52.1 #1918
Patch release: V0.52.1 #1918
Conversation
The tag will be made from the last commit here before merging to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This PR will bump the version to the next point patch version ( |
I've been made aware that the latest release of xarray contains my changes concerning the "decimal_year" stuff which has broken xclim. I'll try to insert a fix here today! |
@aulemahal v0.52.1 has already been released, unfortunately. I might need to push another patch, haha. |
And I even approved the deployment 🙃 . I was mislead by the fact that this PR was still open ;)! |
Well, this could have been expected from my decision to use a private function that I myself removed... But I had forgotten that we were explicitly using it. So this fixes xclim with xarray 2024.09.0 by having a try-except for the import of the decimal year stuff. Also, removed the deprecated function. As of xarray 2024.09, the "decimal year" can be calculated through `times.dt.decimal_year`, no need to use a private function. This also adds the missing `branch` specifiers to `open_dataset` calls in the notebooks. --------- Co-authored-by: Trevor James Smith <[email protected]>
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
### What kind of change does this PR introduce? * Prepares the next patch release.
Pull Request Checklist:
number
) and pull request (:pull:number
) has been addedWhat kind of change does this PR introduce?
Does this PR introduce a breaking change?
No.
Other information:
Private: https://github.com/Ouranosinc/pavics-jupyter-env-issues/issues/13#issuecomment-2343804116