Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dOTC small fix #1890

Merged
merged 4 commits into from
Aug 22, 2024
Merged

dOTC small fix #1890

merged 4 commits into from
Aug 22, 2024

Conversation

LamAdr
Copy link
Collaborator

@LamAdr LamAdr commented Aug 21, 2024 •
edited by coxipi
Loading

Pull Request Checklist:

  • This PR addresses an already opened issue (for bug fixes / features)
    • This PR fixes #xyz
  • Tests for the changes have been added (for bug fixes / features)
    • (If applicable) Documentation has been added / updated (for bug fixes / features)
  • CHANGELOG.rst has been updated (with summary of main changes)
    • Link to issue (:issue:number) and pull request (:pull:number) has been added

What kind of change does this PR introduce?

  • Fix an inefficiency in OTC

Does this PR introduce a breaking change?

No

Other information:

Bin groups are in the same order as P.
We don't need to find the cell row.

@github-actions github-actions bot added the sdba Issues concerning the sdba submodule. label Aug 21, 2024
coxipi
coxipi approved these changes Aug 21, 2024
View reviewed changes
Copy link
Contributor

@coxipi coxipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved

@coveralls
Copy link

Coverage Status

coverage: 89.099% (-0.001%) from 89.1%
when pulling e442c19 on LamAdr:dOTC
into ab50716 on Ouranosinc:main.

@LamAdr
Copy link
Collaborator Author

LamAdr commented Aug 21, 2024

@Zeitsperre when you have time can you help me here once again?

@coxipi coxipi added the approved Approved for additional tests label Aug 21, 2024
@LamAdr LamAdr merged commit 67e14e9 into Ouranosinc:main Aug 22, 2024
28 checks passed
@LamAdr LamAdr deleted the dOTC branch August 22, 2024 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coxipi coxipi coxipi approved these changes

Assignees
No one assigned
Labels
approved Approved for additional tests sdba Issues concerning the sdba submodule.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@LamAdr @coveralls @coxipi