-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Deptry, split dev
into dev
and docs
recipes, address bandit security issues
#1806
Conversation
…ts, add deptry to pre-commit, update CONTRIBUTING.rst and installation.rst to modern conventions
# Conflicts: # pyproject.toml
…e linting dependencies
# Conflicts: # CI/requirements_ci.txt
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The meta changes look good, as far as I understand, thanks!
However, I think the change in convert_units_to
is to strict. It would yield incomprehensible error messages to the user.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A suggestion to make the error message even more explicit, but otherwise, this is good to go!
Co-authored-by: Pascal Bourgault <[email protected]>
Pull Request Checklist:
number
) and pull request (:pull:number
) has been addedWhat kind of change does this PR introduce?
deptry
package to the linters for performing dependency analyses (unused or missing)dev
dependencies intodev
anddocs
(both can be installed withall
)flake8-bandit
like checks inruff
, fixes a few security-related checksxclim.testing.utils
now have more secure URL auditing checksDoes this PR introduce a breaking change?
Yes, a new dependency has been added (
deptry
).Also,
xclim
no longer bundles the documentation dependencies with thedev
recipe. Splitting this reduces the number of dependencies needed to run the tests and also helps us know which dependencies are needed and where (determined with the aid ofdeptry
).Other information:
https://deptry.com/
https://docs.astral.sh/ruff/rules/#flake8-bandit-s