Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add vulture to find dead code #1717

Merged
merged 4 commits into from
Apr 18, 2024
Merged

Add vulture to find dead code #1717

merged 4 commits into from
Apr 18, 2024

Conversation

Zeitsperre
Copy link
Collaborator

@Zeitsperre Zeitsperre commented Apr 18, 2024 •
edited
Loading

Pull Request Checklist:

  • This PR addresses an already opened issue (for bug fixes / features)
    • This PR fixes #xyz
  • Tests for the changes have been added (for bug fixes / features)
    • (If applicable) Documentation has been added / updated (for bug fixes / features)
  • CHANGES.rst has been updated (with summary of main changes)
    • Link to issue (:issue:number) and pull request (:pull:number) has been added

What kind of change does this PR introduce?

  • Adds a hook to use vulture, a tool for finding dead code segments using static analysis and confidence intervals
  • Updates the pre-commit hooks to latest versions
  • Removes the obsolete construct_moving_yearly_window and unpack_moving_yearly_window functions

Does this PR introduce a breaking change?

No, the removed functions have been slated for removal for around since the end of year 2023.

Other information:

https://github.com/jendrikseipp/vulture

@Zeitsperre
add vulture to check for dead code, update pre-commit checks
8df0042
@Zeitsperre
add relevant noqa statements, modify some variables to address dead c…
3cd5251 
…ode segments, remove obsolete construct_moving_yearly_window and unpack_moving_yearly_window functions
@github-actions github-actions bot added sdba Issues concerning the sdba submodule. CI Automation and Contiunous Integration indicators Climate indices and indicators labels Apr 18, 2024
@Zeitsperre Zeitsperre requested review from aulemahal and huard April 18, 2024 16:29
@Zeitsperre Zeitsperre self-assigned this Apr 18, 2024
aulemahal
aulemahal approved these changes Apr 18, 2024
View reviewed changes
Copy link
Collaborator

@aulemahal aulemahal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea, this looks good.

@github-actions github-actions bot added the approved Approved for additional tests label Apr 18, 2024
@coveralls
Copy link

Coverage Status

coverage: 90.677% (-0.03%) from 90.703%
when pulling 6e44622 on vulture
into d27b4ed on main.

@Zeitsperre Zeitsperre merged commit 0738b80 into main Apr 18, 2024
30 checks passed
@Zeitsperre Zeitsperre deleted the vulture branch April 18, 2024 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aulemahal aulemahal aulemahal approved these changes

@huard huard Awaiting requested review from huard

Assignees

@Zeitsperre Zeitsperre

Labels
approved Approved for additional tests CI Automation and Contiunous Integration indicators Climate indices and indicators sdba Issues concerning the sdba submodule.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Zeitsperre @coveralls @aulemahal