Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change xscen partition input function name in notebook #1591

Merged
merged 2 commits into from
Jan 12, 2024
Merged

Change xscen partition input function name in notebook #1591

merged 2 commits into from
Jan 12, 2024

Conversation

juliettelavoie
Copy link
Contributor

@juliettelavoie juliettelavoie commented Jan 11, 2024 •
edited
Loading

Pull Request Checklist:

  • This PR addresses an already opened issue (for bug fixes / features)
    • This PR fixes #xyz
  • Tests for the changes have been added (for bug fixes / features)
    • (If applicable) Documentation has been added / updated (for bug fixes / features)
  • CHANGES.rst has been updated (with summary of main changes)
    • Link to issue (:issue:number) and pull request (:pull:number) has been added

What kind of change does this PR introduce?

  • the name of the partition function in xscen changed, so I am changing the reference to it here.

Does this PR introduce a breaking change?

Other information:

@review-notebook-app Review Notebook App
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@github-actions github-actions bot added the docs Improvements to documenation label Jan 11, 2024
@juliettelavoie juliettelavoie requested a review from huard January 11, 2024 16:42
@aulemahal aulemahal changed the title change name Change xscen partition input function name in notebook Jan 11, 2024
@github-actions github-actions bot added the approved Approved for additional tests label Jan 12, 2024
@juliettelavoie juliettelavoie merged commit 07150a7 into master Jan 12, 2024
23 checks passed
@juliettelavoie juliettelavoie deleted the fix-xscen-name branch January 12, 2024 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@huard huard huard approved these changes

Assignees
No one assigned
Labels
approved Approved for additional tests docs Improvements to documenation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@juliettelavoie @huard