-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove faulty default in MRT and UTCI #1501
Conversation
On inspection, the No further action is required. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I think this should be adopted to UTCI as well, isn't it? |
Hi there, we're preparing a new release of xclim no later than tomorrow (24 Oct, 12 PM EST). If you have a minute, please let us know if this PR settles the issue you were experiencing with the MRT index. Thanks! |
Hi @Zeitsperre, thanks for the update. I've tested the fix and have updated @aulemahal on the other thread. I just need him to verify if one of the stat settings is working as expected. Following his response, you can proceed. |
Pull Request Checklist:
number
) and pull request (:pull:number
) has been addedWhat kind of change does this PR introduce?
I believe #1399 changed the meanings of argument
stat
which made the default option ofmean_radiant_temperature
incorrect. This PR removes the "average" option and changes the default to 'sunlit'.Does this PR introduce a breaking change?
Yes, outputs will change. However, I think previous output was incorrect. An announcement has been added to the CHANGES.
Other information: