Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove faulty default in MRT and UTCI #1501

Merged
merged 10 commits into from
Oct 24, 2023
Merged

Remove faulty default in MRT and UTCI #1501

merged 10 commits into from
Oct 24, 2023

Conversation

aulemahal
Copy link
Collaborator

@aulemahal aulemahal commented Oct 13, 2023

Pull Request Checklist:

  • This PR addresses an already opened issue (for bug fixes / features)
  • Tests for the changes have been added (for bug fixes / features)
    • (If applicable) Documentation has been added / updated (for bug fixes / features)
  • CHANGES.rst has been updated (with summary of main changes)
    • Link to issue (:issue:number) and pull request (:pull:number) has been added

What kind of change does this PR introduce?

I believe #1399 changed the meanings of argument stat which made the default option of mean_radiant_temperature incorrect. This PR removes the "average" option and changes the default to 'sunlit'.

Does this PR introduce a breaking change?

Yes, outputs will change. However, I think previous output was incorrect. An announcement has been added to the CHANGES.

Other information:

@github-actions github-actions bot added the indicators Climate indices and indicators label Oct 13, 2023
@github-actions github-actions bot added the CI Automation and Contiunous Integration label Oct 13, 2023
@github-actions
Copy link

Note
It appears that this Pull Request modifies the main.yml workflow.

On inspection, the XCLIM_TESTDATA_BRANCH environment variable is set to the most recent tag (v2023.9.12).

No further action is required.

Copy link
Collaborator

@Zeitsperre Zeitsperre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ludwiglierhammer
Copy link

I think this should be adopted to UTCI as well, isn't it?

@Zeitsperre
Copy link
Collaborator

Zeitsperre commented Oct 23, 2023

@emsonali

Hi there, we're preparing a new release of xclim no later than tomorrow (24 Oct, 12 PM EST). If you have a minute, please let us know if this PR settles the issue you were experiencing with the MRT index. Thanks!

@emsonali
Copy link

Hi @Zeitsperre, thanks for the update. I've tested the fix and have updated @aulemahal on the other thread. I just need him to verify if one of the stat settings is working as expected. Following his response, you can proceed.

@aulemahal aulemahal merged commit 7cf2001 into master Oct 24, 2023
13 checks passed
@aulemahal aulemahal deleted the fix-mrt branch October 24, 2023 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Approved for additional tests CI Automation and Contiunous Integration indicators Climate indices and indicators
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NA values for UTCI - issue with mean radiant temperature calculations?
4 participants