Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust notebooks to xclim-testdata changes #247

Merged
merged 1 commit into from
Sep 4, 2024

Conversation

Zeitsperre
Copy link
Contributor

Pull Request Checklist:

  • This PR addresses an already opened issue (for bug fixes / features)
    • This PR fixes #xyz
  • (If applicable) Documentation has been added / updated (for bug fixes / features).
  • (If applicable) Tests have been added.
  • CHANGELOG.rst has been updated (with summary of main changes).
    • Link to issue (:issue:number) and pull request (:pull:number) has been added.

What kind of change does this PR introduce?

  • Adds the branch name to the xclim.testing.open_dataset calls
  • Cleans up a few comments within the Jupyter code blocks

Does this PR introduce a breaking change?

No. This fixes an issue arising from changes to the testing data.

Other information:

The next release of xclim will have modified xclim.testing utilities. Though, this only really affects a few code blocks, it's likely that these changes will need to be revisited eventually.

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@Zeitsperre
Copy link
Contributor Author

@sarahclaude @juliettelavoie Once this is in, I'll merge the cookiecutter update and the remaining automated PRs should close themselves

Copy link
Collaborator

@sarahclaude sarahclaude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks Trevor

@Zeitsperre Zeitsperre merged commit d342fba into cookiecutter-update Sep 4, 2024
14 checks passed
@Zeitsperre Zeitsperre deleted the update-notebook-apis branch September 4, 2024 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants