Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ON-811: ERC-7904 Wrapper #28

Merged
merged 7 commits into from
Apr 22, 2024
Merged

ON-811: ERC-7904 Wrapper #28

merged 7 commits into from
Apr 22, 2024

Conversation

ernanirst
Copy link
Contributor

This PR introduces an ERC-7432 wrapper for ERC-4907.

Caveats:

  • ERC-4907 has only one role, and does not support custom data.
  • Introduced upgradable contract OriumWrapperManager to manage mapping of tokens and max duration of rentals.

Other changes:

  • Added new ownerOf function to ERC-7432 Vault Extension.

Copy link
Contributor

@karacurt karacurt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OriumWrapperManager is not 100% covered by tests

contracts/ERC7432/ERC7432WrapperForERC4907.sol Outdated Show resolved Hide resolved
contracts/ERC7432/ERC7432WrapperForERC4907.sol Outdated Show resolved Hide resolved
contracts/ERC7432/ERC7432WrapperForERC4907.sol Outdated Show resolved Hide resolved
contracts/ERC7432/ERC7432WrapperForERC4907.sol Outdated Show resolved Hide resolved
@ernanirst ernanirst merged commit 694bbc3 into master Apr 22, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants