Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: #70 - problem with md variable parsing #78

Merged
merged 1 commit into from
Feb 26, 2024

Conversation

r3dp0int
Copy link
Contributor

@r3dp0int r3dp0int commented Feb 10, 2024

As raised in issue #70, Arsenal was not correctly parsing cheats that contained a colon (:) within <>.
I have removed the colon that was found within the arg_name regex check in command.py, as I don't believe this is needed for command argument parsing.
I have checked it across multiple commands and have found no errors.

Copy link
Collaborator

@Guilhem7 Guilhem7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi thanks for your PR !

It actually fixes some command parsing issues like the one here:
secretsdump local dump - extract hash from ntds.dit

Thanks again

@v1k1ngfr v1k1ngfr merged commit bc84d58 into Orange-Cyberdefense:master Feb 26, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants