Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sd256 raft nb fixes #576

Merged
merged 2 commits into from
Aug 1, 2023
Merged

Conversation

tpaviot
Copy link
Contributor

@tpaviot tpaviot commented Jul 25, 2023

The SD256-RAFT notebook needs these two commits to correctly run on my google colab account.

Copy link
Contributor

@deepgoyal19 deepgoyal19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes seems fine.

Accelerator no longer uses logging_dir and have changed it to project_dir.

@hendrydong
Copy link
Contributor

LGTM

@hendrydong hendrydong merged commit 613bba0 into OptimalScale:main Aug 1, 2023
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants