Merge pull request #56 from OpsLevel/kr/wording_improvements

Make wording improvements
OpsLevel · Dec 23, 2024 · 33988bf · 33988bf
2 parents 882d5cc + a867a4f
commit 33988bf
Show file tree

Hide file tree

Showing 4 changed files with 63 additions and 16 deletions.
diff --git a/modules/demo_account/rubric_bronze.tf b/modules/demo_account/rubric_bronze.tf
@@ -45,7 +45,7 @@ module "branch_protection" {
 module "has_sentry" {
   source = "../check/tool_usage"
 
-  name     = "Sentry Integrated"
+  name     = "Has Error Tracking"
   category = opslevel_rubric_category.all["reliability"].id
   level    = opslevel_rubric_level.all["bronze"].id
   owner    = module.internal-tools-team.this.id
@@ -61,7 +61,7 @@ module "has_sentry" {
 module "has_deployed_this_qtr" {
   source = "../check/has_recent_deploy"
 
-  name     = "Has Deployed this Quarter"
+  name     = "[UPCOMING] Has Deployed this Quarter"
   category = opslevel_rubric_category.all["observability"].id
   level    = opslevel_rubric_level.all["bronze"].id
   owner    = module.internal-tools-team.this.id
@@ -70,4 +70,14 @@ module "has_deployed_this_qtr" {
   days = 90
 }
 
+module "has_dependencies" {
+  source = "../check/service_dependency"
+
+  name     = "Has Defined Dependencies"
+  category = opslevel_rubric_category.all["observability"].id
+  level    = opslevel_rubric_level.all["bronze"].id
+  owner    = module.internal-tools-team.this.id
+  enabled  = true
+}
+
 # No Critical Vulns - security
diff --git a/modules/demo_account/rubric_gold.tf b/modules/demo_account/rubric_gold.tf
@@ -37,7 +37,7 @@ module "has_runbooks" {
 module "slos_defined" {
   source = "../check/manual"
 
-  name     = "Has SLOs Defined"
+  name     = "[UPCOMING] Has SLOs Defined"
   category = opslevel_rubric_category.all["reliability"].id
   level    = opslevel_rubric_level.all["gold"].id
   owner    = module.internal-tools-team.this.id
@@ -72,21 +72,23 @@ module "has_deployed_this_sprint" {
   days = 14
 }
 
-module "github_check_package_version" {
+module "check_package_version_testutils" {
   source = "../check/package_version"
 
-  name     = "Uses Latest Github Actions Checkout"
+  name     = "Uses Latest Test Framework"
   category = opslevel_rubric_category.all["security"].id
   level    = opslevel_rubric_level.all["gold"].id
   owner    = module.internal-tools-team.this.id
   enabled  = true
 
   package_constraint     = "matches_version"
-  package_manager        = "github"
-  package_name           = "actions/checkout"
+  package_manager        = "golang"
+  package_name           = "github.com/stretchr/testify"
   missing_package_result = "passed"
   version_constraint_predicate = {
     type  = "matches_regex"
-    value = "^v5.*"
+    value = "^v1.9.*"
   }
 }
+
+
diff --git a/modules/demo_account/rubric_platinum.tf b/modules/demo_account/rubric_platinum.tf
@@ -12,7 +12,7 @@ module "manual_approval" {
 module "has_gremlin" {
   source = "../check/tool_usage"
 
-  name     = "Gremlin Integrated"
+  name     = "Performs Choas Experiments"
   category = opslevel_rubric_category.all["reliability"].id
   level    = opslevel_rubric_level.all["platinum"].id
   owner    = module.internal-tools-team.this.id
@@ -32,7 +32,7 @@ module "has_gremlin" {
 module "has_sentry_stg" {
   source = "../check/tool_usage"
 
-  name     = "Sentry Integrated in Staging"
+  name     = "Has Error Tracking in Staging"
   category = opslevel_rubric_category.all["reliability"].id
   level    = opslevel_rubric_level.all["platinum"].id
   owner    = module.internal-tools-team.this.id
@@ -59,4 +59,23 @@ module "mttr" {
     type  = "equals"
     value = "2"
   }
-}
+}
+
+module "check_package_version_codecov" {
+  source = "../check/package_version"
+
+  name     = "Uses Latest CodeCov"
+  category = opslevel_rubric_category.all["security"].id
+  level    = opslevel_rubric_level.all["platinum"].id
+  owner    = module.internal-tools-team.this.id
+  enabled  = true
+
+  package_constraint     = "matches_version"
+  package_manager        = "github"
+  package_name           = "codecov/codecov-action"
+  missing_package_result = "passed"
+  version_constraint_predicate = {
+    type  = "matches_regex"
+    value = "^v4.*"
+  }
+}
diff --git a/modules/demo_account/rubric_silver.tf b/modules/demo_account/rubric_silver.tf
@@ -13,7 +13,7 @@ module "service_lifecycle_defined" {
 module "has_splunk" {
   source = "../check/tool_usage"
 
-  name     = "Splunk Integrated"
+  name     = "Has Logging Dashboard"
   category = opslevel_rubric_category.all["observability"].id
   level    = opslevel_rubric_level.all["silver"].id
   owner    = module.internal-tools-team.this.id
@@ -29,7 +29,7 @@ module "has_splunk" {
 module "has_datadog" {
   source = "../check/tool_usage"
 
-  name     = "Datadog Integrated"
+  name     = "Has Monitoring Dashboard"
   category = opslevel_rubric_category.all["observability"].id
   level    = opslevel_rubric_level.all["silver"].id
   owner    = module.internal-tools-team.this.id
@@ -45,7 +45,7 @@ module "has_datadog" {
 module "has_pagerduty" {
   source = "../check/tool_usage"
 
-  name     = "PagerDuty Integrated"
+  name     = "Has Alerting/Paging System"
   category = opslevel_rubric_category.all["reliability"].id
   level    = opslevel_rubric_level.all["silver"].id
   owner    = module.internal-tools-team.this.id
@@ -74,5 +74,21 @@ module "fast_builds" {
   }
 }
 
-# Log4J - Security
-# No High vulns - security
+module "package_version_github_checkout" {
+  source = "../check/package_version"
+
+  name     = "Uses Latest GA Checkout"
+  category = opslevel_rubric_category.all["security"].id
+  level    = opslevel_rubric_level.all["silver"].id
+  owner    = module.internal-tools-team.this.id
+  enabled  = true
+
+  package_constraint     = "matches_version"
+  package_manager        = "github"
+  package_name           = "actions/checkout"
+  missing_package_result = "passed"
+  version_constraint_predicate = {
+    type  = "matches_regex"
+    value = "^v5.*"
+  }
+}