add AffectsOverallServiceLevels field to Scorecard and ScorecardInput

[davidbloss]

Issues

#71

Changelog

Add AffectsOverallServiceLevels field to Scorecard and ScorecardInput structs

• List your changes here
• Make a changie entry

Tophatting

task test passes all tests

[codecov]

Codecov Report

Merging #282 (55e98d3) into main (eb1f300) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #282      +/-   ##
==========================================
- Coverage   77.45%   77.43%   -0.02%     
==========================================
  Files          50       50              
  Lines        3335     3333       -2     
==========================================
- Hits         2583     2581       -2     
  Misses        549      549              
  Partials      203      203              

Files	Coverage Δ
common.go	94.59% <100.00%> (-0.28%)	⬇️
scorecards.go	90.16% <ø> (ø)

[ghost]

I'm confused about this change and the function in general, doesn't this have a different result than the comment above this function?

[rocktavious]

@taimoor-at-opslevel So the problem is that you cannot do this

input := ScorecardInput{
  AffectsOverallServiceLevels: &true
}

So you have two ways to fix it - pass the bool value through a function to get it stored in a var and then return the address of the variable

input := ScorecardInput{
  AffectsOverallServiceLevels: ol.Bool(true)
}

OR make a local var and give the address

myBool := true
input := ScorecardInput{
  AffectsOverallServiceLevels: &myBool
}

[rocktavious]

The way the function was originally written was unnecessary - its creates an unneeded pointer - the way David fixed it is more idomatic go.

But you are right we should probably adjust the function docstring

[rocktavious]

Gonna merge this and fixup the doc string later