Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Variables to TestRequest struct, update tests #264

Merged
merged 1 commit into from
Oct 3, 2023

Conversation

davidbloss
Copy link
Contributor

Issues

#100

Changelog

Add Variables to TestRequest struct. First step toward improving testing.

  • List your changes here
  • Make a changie entry

Tophatting

All tests still pass - task test

@davidbloss davidbloss requested review from rocktavious and a user October 3, 2023 17:40
@codecov
Copy link

codecov bot commented Oct 3, 2023

Codecov Report

Merging #264 (c9244d2) into main (c89bf85) will not change coverage.
Report is 3 commits behind head on main.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #264   +/-   ##
=======================================
  Coverage   77.77%   77.77%           
=======================================
  Files          50       50           
  Lines        3275     3275           
=======================================
  Hits         2547     2547           
  Misses        531      531           
  Partials      197      197           

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I don't think a changie entry is necessary but I'll leave that up to you.

@davidbloss davidbloss merged commit c5cf856 into main Oct 3, 2023
5 checks passed
@davidbloss davidbloss deleted the db/update-TestRequest-improve-testing branch October 3, 2023 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant