feat(protocol-designer): mixpanel events pt2 redesign #16758
+193
−38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koji
reviewed
Nov 13, 2024
| @@ -39,6 +50,19 @@ import type { SetFeatureFlagAction } from '../feature-flags/actions' | |||
| import type { CreatePipettesAction } from '../step-forms/actions' | |||
| import type { AnalyticsEventAction } from './actions' | |||
| import type { AnalyticsEvent } from './mixpanel' | |||
|
|
|||
| const PIPETTING_ARGS_FILTER_LIST = [ | |||
There was a problem hiding this comment.
what does the strikethrough mean in the spreadsheet?
https://docs.google.com/spreadsheets/d/1AiFdoyO0M4r3eDJ6s9Qpvqk0rCt2P-HWdQjqLXmU5Vs/edit?gid=1585271769#gid=1585271769
There was a problem hiding this comment.
it means we don't want to record the field values for some reason (or we want to rename it) - Felix decided on the list
koji
reviewed
Nov 13, 2024
koji
reviewed
Nov 13, 2024
koji
reviewed
Nov 13, 2024
protocol-designer/src/pages/Designer/ProtocolSteps/StepForm/StepFormToolbox.tsx
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes AUTH-1017
Overview
Refactor the pipetting args and add an event in for formWarnings and formErrors
Test Plan and Hands on Testing
Review the code, i checked that it works in mixpanel correctly!
Changelog
Risk assessment
low