Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: biginteger implementation #495

Draft
wants to merge 63 commits into
base: main
Choose a base branch
from

Conversation

qalisander
Copy link
Member

Resolves #481

PR Checklist

  • Tests
  • Documentation
  • Changelog

Copy link

netlify bot commented Jan 15, 2025

Deploy Preview for contracts-stylus canceled.

Name Link
🔨 Latest commit d3df6cc
🔍 Latest deploy log https://app.netlify.com/sites/contracts-stylus/deploys/678798de0308f500080f51a4

Copy link

codecov bot commented Jan 15, 2025

Codecov Report

Attention: Patch coverage is 55.08850% with 406 lines in your changes missing coverage. Please review.

Project coverage is 84.4%. Comparing base (e8b6c7d) to head (d3df6cc).

Files with missing lines Patch % Lines
lib/crypto/src/arithmetic/mod.rs 52.8% 294 Missing ⚠️
lib/crypto/src/field/fp.rs 65.1% 90 Missing ⚠️
lib/crypto/src/const_helpers.rs 0.0% 22 Missing ⚠️
Additional details and impacted files
Files with missing lines Coverage Δ
lib/crypto/src/field/mod.rs 100.0% <ø> (ø)
lib/crypto/src/field/prime.rs 0.0% <ø> (ø)
lib/crypto/src/poseidon2/mod.rs 93.2% <ø> (ø)
lib/crypto/src/const_helpers.rs 0.0% <0.0%> (ø)
lib/crypto/src/field/fp.rs 57.5% <65.1%> (+8.9%) ⬆️
lib/crypto/src/arithmetic/mod.rs 52.8% <52.8%> (ø)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's great you have done these benchmarks but I am not a fan of maintaining akr-ff or poseidon-renegades. We may want. to have just a separated branch with these benchmarks.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was about to drop it. It is just for comparison, when I was optimizing it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]: BigInteger implementation
2 participants