Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref: Remove rand Dev Dependency from ./contracts/* #490

Merged
merged 7 commits into from
Jan 14, 2025
Merged

Conversation

0xNeshi
Copy link
Collaborator

@0xNeshi 0xNeshi commented Jan 13, 2025

Resolves #435

PR Checklist

  • Tests
  • Documentation
  • Changelog

@0xNeshi 0xNeshi self-assigned this Jan 13, 2025
Copy link

netlify bot commented Jan 13, 2025

Deploy Preview for contracts-stylus canceled.

Name Link
🔨 Latest commit 6bb3526
🔍 Latest deploy log https://app.netlify.com/sites/contracts-stylus/deploys/6784d82ab078e10008c0867a

Copy link

netlify bot commented Jan 13, 2025

Deploy Preview for contracts-stylus canceled.

Name Link
🔨 Latest commit e6b88a3
🔍 Latest deploy log https://app.netlify.com/sites/contracts-stylus/deploys/6786616eaf17c100087b7111

@0xNeshi 0xNeshi requested a review from ggonzalez94 January 13, 2025 09:24
Copy link

codecov bot commented Jan 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.6%. Comparing base (badee40) to head (e6b88a3).
Report is 1 commits behind head on main.

Additional details and impacted files
Files with missing lines Coverage Δ
...racts/src/token/erc1155/extensions/metadata_uri.rs 72.0% <100.0%> (-3.9%) ⬇️
...tracts/src/token/erc1155/extensions/uri_storage.rs 98.0% <100.0%> (-0.2%) ⬇️
contracts/src/token/erc721/extensions/burnable.rs 100.0% <100.0%> (ø)
...ntracts/src/token/erc721/extensions/consecutive.rs 97.9% <100.0%> (-0.1%) ⬇️
...ontracts/src/token/erc721/extensions/enumerable.rs 95.6% <100.0%> (ø)
...ntracts/src/token/erc721/extensions/uri_storage.rs 90.2% <100.0%> (-1.0%) ⬇️
contracts/src/token/erc721/mod.rs 97.0% <100.0%> (-0.2%) ⬇️

@0xNeshi 0xNeshi marked this pull request as ready for review January 13, 2025 09:26
@0xNeshi 0xNeshi changed the title ref: Remove rand Dependency from _/contracts/_ ref: Remove rand Dependency from ./contracts/* Jan 13, 2025
@0xNeshi 0xNeshi changed the title ref: Remove rand Dependency from ./contracts/* ref: Remove rand Dev Dependency from ./contracts/* Jan 13, 2025
Copy link
Collaborator

@bidzyyys bidzyyys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bidzyyys bidzyyys merged commit 4b5cedb into main Jan 14, 2025
26 checks passed
@bidzyyys bidzyyys deleted the rem-rand-dep branch January 14, 2025 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]: Remove rand Dependency from _/contracts/_
3 participants