Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref: Add/Sub Assignment Operations + e2e-tests.sh #467

Merged
merged 24 commits into from
Jan 2, 2025
Merged

Conversation

0xNeshi
Copy link
Collaborator

@0xNeshi 0xNeshi commented Dec 26, 2024

Resolves #445, Resolves #444

PR Checklist

  • Tests
  • Documentation
  • Changelog

@0xNeshi 0xNeshi self-assigned this Dec 26, 2024
Copy link

netlify bot commented Dec 26, 2024

Deploy Preview for contracts-stylus canceled.

Name Link
🔨 Latest commit c5c7be5
🔍 Latest deploy log https://app.netlify.com/sites/contracts-stylus/deploys/6773bc6601658c0008e64e64

Copy link

codecov bot commented Dec 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.6%. Comparing base (3205fc7) to head (c5c7be5).
Report is 1 commits behind head on main.

Additional details and impacted files
Files with missing lines Coverage Δ
contracts/src/access/control.rs 98.5% <ø> (ø)
contracts/src/access/ownable.rs 94.1% <ø> (ø)
contracts/src/access/ownable_two_step.rs 99.2% <ø> (ø)
contracts/src/finance/vesting_wallet.rs 55.6% <ø> (ø)
...racts/src/token/erc1155/extensions/metadata_uri.rs 78.5% <ø> (ø)
contracts/src/token/erc1155/extensions/supply.rs 81.1% <ø> (ø)
...tracts/src/token/erc1155/extensions/uri_storage.rs 98.2% <ø> (ø)
contracts/src/token/erc1155/mod.rs 96.9% <ø> (ø)
contracts/src/token/erc20/extensions/capped.rs 83.3% <ø> (ø)
contracts/src/token/erc20/extensions/metadata.rs 22.2% <ø> (ø)
... and 12 more

@0xNeshi 0xNeshi requested a review from ggonzalez94 December 26, 2024 18:39
Copy link
Collaborator

@bidzyyys bidzyyys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe we can apply #[allow(clippy::used_underscore_binding)] for the whole contracts library

@bidzyyys bidzyyys self-requested a review December 27, 2024 08:36
Copy link
Collaborator

@bidzyyys bidzyyys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments, good job @0xNeshi

CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
contracts/src/utils/nonces.rs Outdated Show resolved Hide resolved
contracts/src/utils/nonces.rs Outdated Show resolved Hide resolved
contracts/src/utils/nonces.rs Outdated Show resolved Hide resolved
contracts/src/utils/nonces.rs Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@bidzyyys bidzyyys self-requested a review December 27, 2024 11:04
Copy link
Collaborator

@bidzyyys bidzyyys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost ready to merge!

contracts/src/utils/nonces.rs Outdated Show resolved Hide resolved
contracts/src/utils/nonces.rs Outdated Show resolved Hide resolved
contracts/src/access/control.rs Show resolved Hide resolved
@0xNeshi 0xNeshi requested a review from bidzyyys December 30, 2024 07:57
Copy link
Collaborator

@bidzyyys bidzyyys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

contracts/src/finance/vesting_wallet.rs Show resolved Hide resolved
scripts/e2e-tests.sh Show resolved Hide resolved
Copy link
Member

@qalisander qalisander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!

scripts/e2e-tests.sh Show resolved Hide resolved
scripts/e2e-tests.sh Show resolved Hide resolved
examples/erc20/src/lib.rs Show resolved Hide resolved
contracts/src/utils/math/storage.rs Outdated Show resolved Hide resolved
contracts/src/access/control.rs Show resolved Hide resolved
@0xNeshi 0xNeshi requested a review from qalisander December 31, 2024 07:34
Copy link
Member

@qalisander qalisander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bidzyyys bidzyyys added this to the Release v0.2.0 milestone Jan 2, 2025
@bidzyyys bidzyyys self-requested a review January 2, 2025 14:39
Copy link
Collaborator

@bidzyyys bidzyyys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@bidzyyys bidzyyys merged commit 3ab0f31 into main Jan 2, 2025
24 checks passed
@bidzyyys bidzyyys deleted the return-res-refactor branch January 2, 2025 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants