Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add short setup guide to GUIDELINES.md #410

Merged
merged 7 commits into from
Nov 20, 2024
Merged

Conversation

0xNeshi
Copy link
Collaborator

@0xNeshi 0xNeshi commented Nov 15, 2024

This was the minimum amount of steps that took me to set up the repo and successfully run e2e tests

@0xNeshi 0xNeshi added the type: docs Changes to documentation. label Nov 15, 2024
@0xNeshi 0xNeshi requested a review from ggonzalez94 November 15, 2024 09:17
@0xNeshi 0xNeshi self-assigned this Nov 15, 2024
Copy link

netlify bot commented Nov 15, 2024

Deploy Preview for contracts-stylus canceled.

Name Link
🔨 Latest commit 7b1cac3
🔍 Latest deploy log https://app.netlify.com/sites/contracts-stylus/deploys/673c6fadbe48440008de03e5

Copy link
Collaborator

@bidzyyys bidzyyys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left few comments.

GUIDELINES.md Outdated Show resolved Hide resolved
GUIDELINES.md Outdated Show resolved Hide resolved
GUIDELINES.md Outdated Show resolved Hide resolved
GUIDELINES.md Outdated Show resolved Hide resolved
GUIDELINES.md Outdated Show resolved Hide resolved
@0xNeshi 0xNeshi requested a review from bidzyyys November 19, 2024 10:59
Copy link
Collaborator

@bidzyyys bidzyyys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member

@qalisander qalisander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@bidzyyys bidzyyys merged commit 2f2e125 into main Nov 20, 2024
18 checks passed
@bidzyyys bidzyyys deleted the 0xneshi/setup-docs branch November 20, 2024 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: docs Changes to documentation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants