Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ref: improvements to Ownable2Step #404

Merged
merged 3 commits into from
Nov 14, 2024
Merged

ref: improvements to Ownable2Step #404

merged 3 commits into from
Nov 14, 2024

Conversation

bidzyyys
Copy link
Collaborator

No description provided.

@codecov Codecov
Copy link

codecov bot commented Nov 12, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.3%. Comparing base (17f74d2) to head (03be59b).
Report is 1 commits behind head on ownable-2-step.

Additional details and impacted files
Files with missing lines Coverage Δ
contracts/src/access/ownable_two_step.rs 72.3% <ø> (+6.8%) ⬆️

@bidzyyys bidzyyys marked this pull request as ready for review November 12, 2024 13:09
ggonzalez94
ggonzalez94 reviewed Nov 12, 2024
View reviewed changes
Copy link
Collaborator

@ggonzalez94 ggonzalez94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a question about only_owner

contracts/src/access/ownable_two_step.rs Outdated Show resolved Hide resolved
@bidzyyys bidzyyys merged commit 3405f76 into ownable-2-step Nov 14, 2024
17 checks passed
@bidzyyys bidzyyys deleted the fix/ownable-2-step branch November 14, 2024 23:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xNeshi 0xNeshi 0xNeshi approved these changes

@ggonzalez94 ggonzalez94 ggonzalez94 left review comments

@qalisander qalisander Awaiting requested review from qalisander

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bidzyyys @ggonzalez94 @0xNeshi