Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature]: Remove rand Dependency from _/contracts/_ #435

Closed
1 task done
0xNeshi opened this issue Dec 5, 2024 · 0 comments · Fixed by #490
Closed
1 task done

[Feature]: Remove rand Dependency from _/contracts/_ #435

0xNeshi opened this issue Dec 5, 2024 · 0 comments · Fixed by #490
Assignees
@0xNeshi
Labels
effort: low Easy or tiny task that takes less than a day. good first issue Good for newcomers. priority: 0 Nice-to-have. Willing to ship without this. type: ref A code update that doesn't meaningfully change functionality. type: test Changes to the testing suite.
Milestone
Release v0.2.0

Comments

@0xNeshi
Copy link
Collaborator

0xNeshi commented Dec 5, 2024

What is the feature you would like to see?

It is there only for unit test helper function random_token_id(s), which could be updated to return a hard-coded (list of) token ID.

Original comment #431 (comment)

Contribution Guidelines

  • I agree to follow this project's Contribution Guidelines
@0xNeshi 0xNeshi added priority: 0 Nice-to-have. Willing to ship without this. type: test Changes to the testing suite. good first issue Good for newcomers. effort: low Easy or tiny task that takes less than a day. type: ref A code update that doesn't meaningfully change functionality. labels Dec 5, 2024
@0xNeshi 0xNeshi mentioned this issue Dec 5, 2024
Merged
3 tasks
@bidzyyys bidzyyys added this to the Release v0.2.0 milestone Jan 8, 2025
@0xNeshi 0xNeshi self-assigned this Jan 10, 2025
@0xNeshi 0xNeshi mentioned this issue Jan 13, 2025
Merged
3 tasks
@github-project-automation github-project-automation bot moved this from Todo to Done in Rust Contracts Stylus Jan 14, 2025
@github-project-automation github-project-automation bot moved this from Todo to Done in Rust Contracts Stylus Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@0xNeshi 0xNeshi

Labels
effort: low Easy or tiny task that takes less than a day. good first issue Good for newcomers. priority: 0 Nice-to-have. Willing to ship without this. type: ref A code update that doesn't meaningfully change functionality. type: test Changes to the testing suite.
Projects
Rust Contracts Stylus
Status: Done
Milestone
Release v0.2.0
Development

Successfully merging a pull request may close this issue.

ref: Remove rand Dev Dependency from ./contracts/* OpenZeppelin/rust-contracts-stylus
2 participants
@0xNeshi @bidzyyys