Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add pallet index to multisig #45

Merged
merged 2 commits into from
Dec 4, 2023
Merged

add pallet index to multisig #45

merged 2 commits into from
Dec 4, 2023

Conversation

ozgunozerk
Copy link
Collaborator

fixes #37

@ozgunozerk ozgunozerk added the bug Something isn't working label Dec 1, 2023
@ozgunozerk ozgunozerk added this to the 1st Deliverable milestone Dec 1, 2023
@ozgunozerk ozgunozerk requested review from KitHat and 4meta5 December 1, 2023 13:38
@ozgunozerk ozgunozerk self-assigned this Dec 1, 2023
4meta5
4meta5 requested changes Dec 1, 2023
View reviewed changes
Copy link
Contributor

@4meta5 4meta5 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not see the required code change:

Multisig: pallet_multisig = 16,

@ozgunozerk
Copy link
Collaborator Author

That's weird, in my local, the push was successful, but in remote, it failed... First time happening to me 🤷

Thanks a lot for noticing 🥂

@ozgunozerk ozgunozerk requested a review from 4meta5 December 1, 2023 19:16
@ozgunozerk ozgunozerk enabled auto-merge (squash) December 1, 2023 19:22
@ozgunozerk ozgunozerk merged commit b84c168 into main Dec 4, 2023
1 check passed
@ozgunozerk ozgunozerk deleted the multisig-pallet-idx branch December 4, 2023 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@4meta5 4meta5 4meta5 approved these changes

@KitHat KitHat KitHat approved these changes

Assignees

@ozgunozerk ozgunozerk

Labels
bug Something isn't working
Projects
Substrate Runtime Templates
Status: ✅ Done
Milestone
1st Deliverable MVP
Development

Successfully merging this pull request may close these issues.

🐞 [Bug]: Set pallet-multisig pallet index in runtime
3 participants
@ozgunozerk @KitHat @4meta5