Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Benchmarks update for release #355

Merged
merged 3 commits into from
Nov 4, 2024
Merged

Benchmarks update for release #355

merged 3 commits into from
Nov 4, 2024

Conversation

KitHat
Copy link
Member

@KitHat KitHat commented Nov 3, 2024

Benchmarks ran on our new runtime params. Updated for both templates.

  • Tests

Copy link

netlify bot commented Nov 3, 2024

Deploy Preview for docs-oz-polkadot canceled.

Name Link
🔨 Latest commit 418ac62
🔍 Latest deploy log https://app.netlify.com/sites/docs-oz-polkadot/deploys/672789994a549e0008bae3ab

Copy link
Contributor

@4meta5 4meta5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why don't the generated weights match the WeightInfo trait expected for pallet_asset_manager? I'm assuming that is why the last commit had to be done manually to fix the function signatures for a few weight functions.

@KitHat
Copy link
Member Author

KitHat commented Nov 4, 2024

why don't the generated weights match the WeightInfo trait expected for pallet_asset_manager? I'm assuming that is why the last commit had to be done manually to fix the function signatures for a few weight functions.

Moonbeam's benchmark generator does not match their benchmark trait.
Sounds weird, but it is the state of the things. I am going to check if it fixed already in upstream and if not, report this issue to them.

@KitHat KitHat merged commit 2515d4e into main Nov 4, 2024
7 checks passed
@KitHat KitHat deleted the benchmarks branch November 4, 2024 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

3 participants