Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix workflows and improve docs #39

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix workflows and improve docs #39

wants to merge 1 commit into from

Conversation

ggonzalez94
Copy link
Collaborator

Not urgent, but does a couple things:

  1. It avoids the two workflows from cancelling each other(by prepending the workflow name)
  2. Some slight improvements to the docs of the procedural macro.
    • Make the phrases a bit clearer
    • Change the order of impl_runtime to match that of construct_runtime

@ggonzalez94 ggonzalez94 requested review from KitHat and 4meta5 November 5, 2024 08:16
ggonzalez94
ggonzalez94 commented Nov 5, 2024
View reviewed changes
procedural/src/lib.rs
@@ -71,58 +71,32 @@ pub fn openzeppelin_construct_runtime(_: TokenStream, tokens: TokenStream) -> To
}

/// Runtime API macro wrapper
/// This macro wraps the `impl_runtime_api` macro and provides our implementations of them.
/// This macro wraps the `impl_runtime_api` macro and provides a simpler interface.
/// It also works in the same groupings as our abstractions pallets and to get the runtime API implementations you only need to provide some types.
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@KitHat I wasn't able to understand this phrase. Can you try to make it a bit clearer?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I meant that this macro provides our implementations of runtime apis

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KitHat KitHat KitHat approved these changes

@4meta5 4meta5 4meta5 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Substrate Runtime Templates
Status: 🗒 Backlog
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ggonzalez94 @KitHat @4meta5