Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

impl_runtime_api! and construct_runtime! macro wrappers #21

Merged
merged 9 commits into from
Nov 4, 2024
Merged

impl_runtime_api! and construct_runtime! macro wrappers #21

merged 9 commits into from
Nov 4, 2024

Conversation

KitHat
Copy link
Member

@KitHat KitHat commented Oct 23, 2024

Fixes #7

PR Checklist

  • Documentation

@KitHat KitHat self-assigned this Oct 23, 2024
@KitHat KitHat changed the base branch from main to nikita-construct-runtime October 23, 2024 13:48
@KitHat KitHat force-pushed the nikita-construct-runtime branch from 8e5ed18 to cfa524b Compare October 28, 2024 10:03
@KitHat KitHat force-pushed the nikita-runtime-api branch from fbe8937 to 5577dbb Compare October 29, 2024 12:56
@4meta5
Copy link
Collaborator

4meta5 commented Oct 30, 2024

Please open companion PRs using this macro in the templates to facilitate review :)

@KitHat KitHat force-pushed the nikita-construct-runtime branch from cfa524b to 5c577e8 Compare October 31, 2024 09:23
@KitHat KitHat force-pushed the nikita-runtime-api branch from 5577dbb to b2485a7 Compare October 31, 2024 09:52
@KitHat KitHat force-pushed the nikita-construct-runtime branch from 4ec41ed to 2a223a3 Compare October 31, 2024 13:18
@KitHat KitHat force-pushed the nikita-runtime-api branch from 2a186d0 to ff52ad0 Compare October 31, 2024 14:07
@KitHat KitHat force-pushed the nikita-construct-runtime branch from 2a223a3 to aa1fc20 Compare November 1, 2024 12:13
@KitHat KitHat force-pushed the nikita-runtime-api branch from ff52ad0 to 7f7e2bf Compare November 1, 2024 12:18
@KitHat KitHat mentioned this pull request Nov 1, 2024
Merged
2 tasks
@KitHat KitHat changed the base branch from nikita-construct-runtime to amar-oz-system-wrapper-poc November 3, 2024 09:24
@KitHat KitHat mentioned this pull request Nov 3, 2024
Closed
@KitHat KitHat force-pushed the nikita-runtime-api branch from 6f22e0f to 67c42d4 Compare November 3, 2024 12:23
Base automatically changed from amar-oz-system-wrapper-poc to main November 4, 2024 01:19
4meta5
4meta5 approved these changes Nov 4, 2024
View reviewed changes
Copy link
Collaborator

@4meta5 4meta5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nodes compile in both templates lgtm

@KitHat KitHat force-pushed the nikita-runtime-api branch from 1a0a82a to 839aec5 Compare November 4, 2024 08:16
@KitHat
Copy link
Member Author

KitHat commented Nov 4, 2024

With this PR I merge all macros at the same time.
@ozgunozerk I will create issues about configurable macros later today
@ggonzalez94 i have renamed the crate to the name you proposed in other PR

@KitHat KitHat merged commit eeda2d7 into main Nov 4, 2024
1 check passed
@KitHat KitHat mentioned this pull request Nov 4, 2024
Closed
3 tasks
@ggonzalez94 ggonzalez94 changed the title impl_runtime_api! macro wrapper impl_runtime_api! and construct_runtime! macro wrappers Nov 4, 2024
@ggonzalez94 ggonzalez94 mentioned this pull request Nov 4, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ozgunozerk ozgunozerk ozgunozerk approved these changes

@4meta5 4meta5 4meta5 approved these changes

@ggonzalez94 ggonzalez94 Awaiting requested review from ggonzalez94

Assignees

@KitHat KitHat

Labels
None yet
Projects
Substrate Runtime Templates
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Runtime API wrapper
3 participants
@KitHat @4meta5 @ozgunozerk