Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused rounding modes Trunc and Expand #5412

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

barakman
Copy link
Contributor

Fixes #5411

In the Rounding-Modes API (in the Math library):

    enum Rounding {
        Floor, // Toward negative infinity
        Ceil, // Toward positive infinity
        Trunc, // Toward zero
        Expand // Away from zero
    }

Remove the last two options, which are not in use throughout the codebase.

PR Checklist

  • Tests
  • Documentation
  • Changeset entry (run npx changeset add)

Copy link

changeset-bot bot commented Dec 30, 2024

⚠️ No Changeset found

Latest commit: c0eae73

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@barakman
Copy link
Contributor Author

⚠️ No Changeset found

Latest commit: 6a441be

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets
Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

This PR introduces an API-breaking change, so in theory, the changeset should include a major-version update.
On the other hand, the changed part in the API is not used anywhere in the current version, so it is possible that a minor-version update or even a patch-version update will suffice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Simplify Rounding Modes
1 participant