Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update links to the eth_sign JSON-RPC method in MessageHashUtils #5407

Merged

Conversation

emretepedev
Copy link
Contributor

The current documentation references https://eth.wiki/json-rpc/API#eth_sign which is no longer accessible. This PR updates the link to the current Ethereum documentation at https://ethereum.org/en/developers/docs/apis/json-rpc/#eth_sign

  • Replace eth.wiki link with official ethereum.org documentation

PR Checklist

  • Tests
  • Documentation
  • Changeset entry (run npx changeset add)

Copy link

changeset-bot bot commented Dec 26, 2024

⚠️ No Changeset found

Latest commit: 1b3185c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Member

@ernestognw ernestognw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ernestognw ernestognw merged commit dd04dfe into OpenZeppelin:master Dec 27, 2024
20 of 21 checks passed
Copy link

gitpoap-bot bot commented Dec 27, 2024

Congrats, your important contribution to this open-source project has earned you a GitPOAP!

GitPOAP: 2024 OpenZeppelin Contracts Contributor:

GitPOAP: 2024 OpenZeppelin Contracts Contributor GitPOAP Badge

Head to gitpoap.io & connect your GitHub account to mint!

Learn more about GitPOAPs here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants