Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add symbol length and character validation #5404

Closed
wants to merge 1 commit into from
Closed

fix: add symbol length and character validation #5404

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions contracts/token/ERC721/ERC721.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,20 @@ abstract contract ERC721 is Context, ERC165, IERC721, IERC721Metadata, IERC721Er
* @dev Initializes the contract by setting a `name` and a `symbol` to the token collection.
*/
constructor(string memory name_, string memory symbol_) {
require(bytes(symbol_).length <= 11, "ERC721: symbol too long");

bytes memory symbolBytes = bytes(symbol_);
for(uint i = 0; i < symbolBytes.length; i++) {
bytes1 char = symbolBytes[i];
require(
char != bytes1('<') &&
char != bytes1('>') &&
char != bytes1('{') &&
char != bytes1('}'),
"ERC721: invalid symbol character"
);
}

_name = name_;
_symbol = symbol_;
}
Expand Down
Loading