fix: add symbol length and character validation #5404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add maximum length check (11 characters) - Add validation for potentially dangerous characters - Fixes OpenZeppelin#5398
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request adds validation for token symbol length and potentially dangerous characters to improve the security and usability of the
ERC721contract.Changes:
<,>,{,}) in the token symbol.Fixes
Fixes #5398
PR Checklist
npx changeset add)This pull request adheres to the repository's contributing guidelines, security policy, and code of conduct. Please ensure all necessary checks are completed before merging.
👋 Welcome to the project! If this is your first contribution, thank you for helping improve OpenZeppelin! Be sure to review the contributing guidelines and code of conduct for more details.