-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce SimpleMerkleTree & migrate to ethers.js #31
Conversation
Using the ethers package increases the installation size from 7.2M to 24M... I would not do that. It's heavy and a lot of people are using Viem now, so I think it would be better for this library to stay agnostic. We can install the bytes utilities only with the package |
Is there an easy way to check the install size of a package you are working on ? |
Not that I know of. I did Is there an issue with native bigint? |
The issue is that I don't think about them |
Replaced by #36 |
Fixes #30
Partially Fixes #13
This PR:
leafHash
which is irrelevantRational:
Merkle tree have been built using other tools before this library was available. Some of these trees do not use double hashing, and are thus not representable using the existing
StandardMerkleTree
class. This prevents devs that have to deal with these trees from using this library.The goal is NOT to encourage not using double hashes. StandardMerkleTree should be prefered for new trees. The goal is to provide a migration path to user that would want to manipulate old trees with this new library.
TODO