-
Notifications
You must be signed in to change notification settings - Fork 692
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Solidity Version and Refactor Contracts to Remove SafeMath Redundancy #763
Open
floor-licker
wants to merge
15
commits into
OpenZeppelin:master
Choose a base branch
from
floor-licker:pragma-safeMath-refactor
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Update Solidity Version and Refactor Contracts to Remove SafeMath Redundancy #763
floor-licker
wants to merge
15
commits into
OpenZeppelin:master
from
floor-licker:pragma-safeMath-refactor
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR provides improvements to the Solidity codebase by updating to v0.8.0 and refactoring the contracts to remove the dependency on SafeMath.
Upgrade to Solidity v0.8.0
Solidity 0.8 introduces built-in overflow and underflow checks, which eliminate the need for external libraries like SafeMath. Solidity 0.8 also introduces gas optimizations for arithmetic operations, so this update not only streamlines contract execution but could also lower gas costs for end users. Solidity 0.8’s built-in overflow/underflow checks are also more robust and efficient compared to the SafeMath library, which reduces the attack surface of the smart contracts.
SafeMath Removal
In updating to Solidity v0.8.0, the built-in safety features make the dependency on the safeMath library redundant. In doing this we remove the dependency on this external library and improve code readability.
This change improves security, maintainability, and gas efficiency. I believe this update is an important step toward keeping up to date with modern best practices in the ETH development community.
I appreciate feedback and am happy to assist with any further improvements or testing required. Please don’t hesitate to reach out.
My Telegram and X accounts are both linked in my bio.