Refactor: Replace deprecated Address.isContract() with dest_.code.length > 0
#743
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…gth > 0 Updated the transfer function in Coin contract to use dest_.code.length > 0 instead of Address.isContract() as the latter is deprecated in OpenZeppelin.
|
Hey @0xScratch , you are right. Nonetheless, this level currently uses OpenZeppelin contracts fixed at version 4.7.3, where the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on the
Good Samaritanchallenge, I encountered an error in Visual Studio Code indicating that the.isContract()function is no longer available in the Address library.Found this pull request in the OpenZeppelin repository, which details the removal of the
.isContract()function. The recommended approach is to useaddress(...).code.length > 0instead...Thanks!