deprecate goerli (+ zksync, base, arbitrum, optimism) #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CoveMB
commented
Apr 5, 2024
| @@ -775,7 +775,6 @@ export default class DefenderDeploy { | |||
| notificationChannels: match.notifyConfig?.notifications.map( | |||
| (n: DefenderNotificationReference) => n.notificationId, | |||
| ), | |||
| severityLevel: match.notifyConfig?.severityLevel, | |||
There was a problem hiding this comment.
@shahnami Had a type issue here does it make sense to remove it?
There was a problem hiding this comment.
No, you'll need to yarn link the latest SDK main branch since the SDK hasn't been published yet.
shahnami
approved these changes
Apr 6, 2024
Closed
…and-related-assets
MCarlomagno
approved these changes
Apr 19, 2024
tirumerla
reviewed
Apr 29, 2024
| | `"zksync-sepolia"` | | | ||
| | `"base"` | | | ||
| | `"base-goerli"` | | | ||
| | `"base-sepolia"` | | | ||
| | `"linea-goerli"` | | |
| @@ -11,7 +11,6 @@ | |||
| | `"mainnet"` | | | |||
| | `"sepolia"` | | | |||
| | `"holesky"` | | | |||
| | `"goerli"` | | | |||
| | `"xdai"` | | | |||
| | `"sokol"` | | | |||
There was a problem hiding this comment.
sokol is also deprecated
tirumerla
deleted the
plat-3311-remove-support-for-goerli-network-and-related-assets
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
deprecate goerli (+ zksync, base, arbitrum, optimism)