fix(scripts): replace matched interface in original place #553
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Previous we miss some ports in GatewayEndpoint. And we fix that in #552 . However, previous scripts failed to handle these ports. |
xiaokamikami
previously approved these changes
Jan 16, 2025
klin02
force-pushed
the
fix-interface-scripts
branch
from
9b5515a to
cf30b0d
Compare
xiaokamikami
previously approved these changes
Jan 16, 2025
klin02
force-pushed
the
fix-interface-scripts
branch
from
cf30b0d to
f1bd028
Compare
Previous this scripts cannot handle port of GatewayEndpoint correctly. This change restrict replace range inside module ports. And replace signal without dot prefix inside module.
klin02
force-pushed
the
fix-interface-scripts
branch
from
f1bd028 to
31862f9
Compare
Tang-Haojin
approved these changes
Jan 16, 2025
|
why do you guys all go to sleep so late |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previosu this scripts cannot handle port of GatewayEndpoint correctly.
This change restrict replace range inside module ports. And replace target in its original place.