Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vcs: fix the max-cycles argument in top #198

Merged
merged 1 commit into from
Oct 21, 2023
Merged

vcs: fix the max-cycles argument in top #198

merged 1 commit into from
Oct 21, 2023

Conversation

poemonsense
Copy link
Member

When difftest is not ticked for every clock cycle, the cycles variable may be updated incorrectly. We move the implementation to Verilog to fix it.

@poemonsense poemonsense force-pushed the fix-max-cycles branch 2 times, most recently from 954285b to fe44e3d Compare October 20, 2023 14:29
@poemonsense poemonsense changed the title vcs: move the max-cycles to Verilog vcs: fix the max-cycles in top Oct 20, 2023
@poemonsense poemonsense changed the title vcs: fix the max-cycles in top vcs: fix the max-cycles argument in top Oct 20, 2023
@poemonsense poemonsense force-pushed the fix-max-cycles branch 2 times, most recently from 6af614a to a7f2773 Compare October 20, 2023 14:32
@poemonsense
vcs: fix the max-cycles argument in top
50d71ff 
When difftest is not ticked for every clock cycle, the cycles variable
may be updated incorrectly. We move the implementation to Verilog
to fix it.
@poemonsense poemonsense merged commit 00996fa into master Oct 21, 2023
3 checks passed
@poemonsense poemonsense deleted the fix-max-cycles branch October 21, 2023 01:19
fawangZ pushed a commit that referenced this pull request Dec 6, 2023
@poemonsense @fawangZ
vcs: fix the max-cycles argument in top (#198)
88e50c6 
When difftest is not ticked for every clock cycle, the cycles variable
may be updated incorrectly. We move the implementation to Verilog
to fix it.
xiaokamikami pushed a commit that referenced this pull request Dec 28, 2023
@poemonsense @xiaokamikami
vcs: fix the max-cycles argument in top (#198)
1196c00 
When difftest is not ticked for every clock cycle, the cycles variable
may be updated incorrectly. We move the implementation to Verilog
to fix it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@poemonsense