Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cpu-o3: refactor KunminghuV3 ideal params configuration #226

Merged
merged 4 commits into from
Dec 12, 2024

Conversation

Lawrence-ID
Copy link
Contributor

@Lawrence-ID Lawrence-ID commented Dec 11, 2024

This commit is NOT expected to impact performance.

  • Added a new runtime parameter '--ideal-kmhv3'. Parameters reset in the setKmhV3IdealParams function now take the highest priority, overriding command-line arguments
  • Parameterized baseTableSize and enableSC in the FTBTAGE class for easier customization
  • Unified numBr into the DecoupledBPUWithFTB class in BranchPredictor.py for better consistency

* Added a new runtime parameter '--ideal-kmhv3'. Parameters defined in the `setKmhV3IdealParams` function now take the highest priority, overriding command-line arguments
* Parameterized `baseTableSize` and `enableSC` in the FTBTAGE class for easier customization
* Unified `numBr` into the DecoupledBPUWithFTB class in BranchPredictor.py for better consistency

Change-Id: Id36cef3e703790dbbd74a36e88444e0955479ad8
Call the `disableAllRegArb` func within `setKmhV3IdealParams` func to disable AllRegArb.

Change-Id: Ie1ea477d428eefcc97346b43326b6b0b64ddc0e9
Copy link
Member

@eastonman eastonman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Change-Id: If5b9e18915d1294c9631dc23c190a93f9d504158
Change-Id: I989cd3c69d0911b6666dffee622ec4c9d741794a
@jensen-yan jensen-yan merged commit 7ed60e9 into xs-dev Dec 12, 2024
3 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants