Fix some minor issues #192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
compiler complains used of uninit var, since assert is removed in fast. Change-Id: I7c9837b31149338f2752d28a8de0092586e55343
Change-Id: I826aeb04e60c89582647e89d036329bf09c86548
this removes compile time warning Change-Id: Idd0407508bbf2580175ab38fe19b59f879b3a616
also remove std::abs on uint64_t RegVal Change-Id: I61ece357501fb186cfe756aa84cc7fad3e9cce39
tastynoob
reviewed
Oct 21, 2024
| @@ -186,7 +186,7 @@ IssueQue::checkScoreboard(const DynInstPtr& inst) | |||
| panic("dst is not load"); | |||
| } | |||
| scheduler->loadCancel(dst_inst); | |||
| DPRINTF(Schedule, "[sn %lu] %s can't get data from bypassNetwork, dst inst: %s\n", | |||
| DPRINTF(Schedule, "[sn:%llu] %s can't get data from bypassNetwork, dst inst: %s\n", | |||
There was a problem hiding this comment.
I actually did this on purpose because this can help us find scheduler‘s log from a lot irrelevant information easier and faster.
It is very useful in scheduler debugging.
There was a problem hiding this comment.
I don't quite understand, can this be achieved by using only the Schedule debug flag?
Recently I have experienced some inconvenience tracking instructions through the scheduler when debugging.
tastynoob
approved these changes
Oct 21, 2024
shinezyy
approved these changes
Oct 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
should be rebase merged.