Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix wrong sorting of parsed language header #2696

Closed
wants to merge 1 commit into from
Closed

Fix wrong sorting of parsed language header #2696

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion openslides_backend/i18n/translator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ def parse_language_header(self, lang_header: str) -> list[str]:
code = code.split("-")[0]
result.append((q, code))
# sort by quality value and return only the codes
return [t[1] for t in sorted(result)]
return [t[1] for t in result]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
return [t[1] for t in result]
return [t[1] for t in sorted(result, key=lambda tup: tup[0])]

The sort did not only sort the languages in alphabetical order: It sorted them by the weight value q first. If that wasn't given or equal to another value, it sorted them in alphabetical order.
I will agree that the latter is probably a bug (in this case caused by the way python sorts tuples), but the former definitely isn't.

The above code should sort the languages by weight first and leave empty values in the same order as before.
If, during testing, it turns out to wrongly prioritize or wrongly not-prioritize languages with no q-value over those with q-value, I'd suggest trying to set q to "0.0" instead of "1.0" in line 50.



Translator = _Translator()
Expand Down